adobe / aem-cloud-service-source-migration

Code refactoring tools for migrating to AEM as a Cloud Service

Apache License 2.0

7 stars 13 forks source link

CQ-4322597 code coverage upload through travis #33

Closed dichaudhary closed 3 years ago

dichaudhary commented 3 years ago

The PR contains changes for uploading report for each package through travis ci integration & common badges are brought out under the root. Also I have tested the integration on my origin (dichaudhary/aem-cloud-service-source-migration), the codecov bot checks the coverage and if the new commit brings down the coverage for the base it simply rejects it.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@21f8f39). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Current head a51a05d differs from pull request most recent head 7fb337e. Consider uploading reports for the commit 7fb337e to get more accurate results

@@            Coverage Diff            @@
##             master      #33   +/-   ##
=========================================
  Coverage          ?   81.56%           
=========================================
  Files             ?       16           
  Lines             ?     1568           
  Branches          ?      154           
=========================================
  Hits              ?     1279           
  Misses            ?      262           
  Partials          ?       27

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 21f8f39...7fb337e. Read the comment docs.

dichaudhary commented 3 years ago

the above is commented by codecov bot since workflow is in place from my origin but it is still not uploaded to codecov since the changes are not yet in master which is the branch configured in codecov yml . everything should work once the PR merges cc: @ukgaurav @ManasMaji @prateek610