adobe / aem-cloud-service-source-migration

Code refactoring tools for migrating to AEM as a Cloud Service
Apache License 2.0
7 stars 13 forks source link

Increase code coverage for repo-modenizer #40

Closed dichaudhary closed 3 years ago

dichaudhary commented 3 years ago

Description

PR contains changes for a few additional test cases for repository modernizer module.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 3 years ago

Codecov Report

Merging #40 (d1013e7) into master (4d7f6db) will increase coverage by 8.03%. The diff coverage is n/a.

:exclamation: Current head d1013e7 differs from pull request most recent head b8ccd6d. Consider uploading reports for the commit b8ccd6d to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   81.51%   89.54%   +8.03%     
==========================================
  Files          16       16              
  Lines        1569     1569              
  Branches      155      155              
==========================================
+ Hits         1279     1405     +126     
+ Misses        263      157     -106     
+ Partials       27        7      -20     
Impacted Files Coverage Δ
...itory-modernizer/src/util/pom-manipulation-util.js 88.63% <0.00%> (+71.59%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4d7f6db...b8ccd6d. Read the comment docs.

dichaudhary commented 3 years ago

The increase of 8% is on the overall repo & detailed increase can be seen here . Also since the other modules contains private functions and one of the way to test them is using rewire (example)which currently has an issue integrating with code coverage (issue) result of which it is difficult to increase the coverage anyfurther.