adobe / aem-cloud-service-source-migration

Code refactoring tools for migrating to AEM as a Cloud Service

Apache License 2.0

7 stars 14 forks source link

CQ-4325182 : LogManager.factory.config issue #46

Closed dichaudhary closed 3 years ago

dichaudhary commented 3 years ago

Description

During transformation , the configs like "{0,date,yyyy-MM-dd HH:mm:ss.SSS} {4} [{3}] {5}" for log manager factory was not getting migrated properly.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

codecov[bot] commented 3 years ago

Codecov Report

Merging #46 (5a860e1) into master (c444e25) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   90.12%   90.12%           
=======================================
  Files          16       16           
  Lines        1600     1600           
  Branches      173      173           
=======================================
  Hits         1442     1442           
  Misses        151      151           
  Partials        7        7

Impacted Files	Coverage Δ
...ckages/repository-modernizer/src/util/constants.js	`100.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c444e25...5a860e1. Read the comment docs.

ukgaurav commented 3 years ago

isnt this follow up of that issue which we fixed for best buy?

dichaudhary commented 3 years ago

@dichaudhary could you also include a test value in one of the test configs so that this is covered by tests (minor change)?

Thanks, @ManasMaji for reminding, I should have thought of it before! my bad! Anyways the changes are done.

dichaudhary commented 3 years ago

isnt this follow up of that issue which we fixed for best buy?

Not sure @ukgaurav , but I have it seen it with almost all project's configs and have resolved it as part of the issue reported in CQ-4325182