adobe / aem-cloud-service-source-migration

Code refactoring tools for migrating to AEM as a Cloud Service
Apache License 2.0
7 stars 13 forks source link

Review Improvements for repository modernizer tool #47

Closed dichaudhary closed 3 years ago

dichaudhary commented 3 years ago

Description

The PR contains changes for :

  1. aem.sdk.api version should be fetched from parent.
  2. plugins used across should have version fetched from reactor pom for other poms.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 3 years ago

Codecov Report

Merging #47 (3a35b33) into master (c444e25) will decrease coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Current head 3a35b33 differs from pull request most recent head 2491882. Consider uploading reports for the commit 2491882 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   90.12%   90.11%   -0.01%     
==========================================
  Files          16       16              
  Lines        1600     1599       -1     
  Branches      173      173              
==========================================
- Hits         1442     1441       -1     
  Misses        151      151              
  Partials        7        7              
Impacted Files Coverage Δ
...ckages/repository-modernizer/src/util/constants.js 100.00% <ø> (ø)
...kages/repository-modernizer/src/restructure-pom.js 89.72% <100.00%> (-0.05%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c444e25...2491882. Read the comment docs.