adobe / aem-cloud-service-source-migration

Code refactoring tools for migrating to AEM as a Cloud Service
Apache License 2.0
7 stars 13 forks source link

CQ-4325771 : Sub Projects not getting transformed properly #50

Closed dichaudhary closed 3 years ago

dichaudhary commented 3 years ago

Description

PR contains changes for transforming sub-projects along with main projects if they are configured

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 3 years ago

Codecov Report

Merging #50 (f1b3edc) into master (3a35b33) will increase coverage by 0.19%. The diff coverage is 94.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   90.11%   90.31%   +0.19%     
==========================================
  Files          16       16              
  Lines        1599     1652      +53     
  Branches      173      199      +26     
==========================================
+ Hits         1441     1492      +51     
- Misses        151      153       +2     
  Partials        7        7              
Impacted Files Coverage Δ
...ckages/repository-modernizer/src/util/constants.js 100.00% <ø> (ø)
...s/repository-modernizer/src/restructure-filters.js 80.58% <91.42%> (+1.21%) :arrow_up:
...ry-modernizer/src/create-base-project-structure.js 92.90% <92.94%> (+0.34%) :arrow_up:
...kages/repository-modernizer/src/restructure-pom.js 90.07% <100.00%> (+0.35%) :arrow_up:
...itory-modernizer/src/util/pom-manipulation-util.js 87.97% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea23596...f1b3edc. Read the comment docs.

dichaudhary commented 3 years ago

@dichaudhary LGTM 👍 Can you also add a small WARN / NOTE in the existingContentPackageFolder under the main projects section saying not to add sub-projects here.

# NOTE : only content packages are expected here, NOT bundle/jar artifacts/sub-projects

Done, thanks @ManasMaji!