adobe / aem-cloud-service-source-migration

Code refactoring tools for migrating to AEM as a Cloud Service
Apache License 2.0
7 stars 13 forks source link

CQ-4330105 : [Dispatcher Converter] Migration failure for AMS based project due to `rules` files inclusion. #70

Closed dichaudhary closed 3 years ago

dichaudhary commented 3 years ago

Description

FileOperations.getXmlContentSync already returns the array of content of file splitted by new line.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 3 years ago

Codecov Report

Merging #70 (140d735) into master (0d65032) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
- Coverage   90.43%   90.43%   -0.01%     
==========================================
  Files          16       16              
  Lines        1684     1683       -1     
  Branches      199      199              
==========================================
- Hits         1523     1522       -1     
  Misses        154      154              
  Partials        7        7              
Impacted Files Coverage Δ
...es/dispatcher-converter/src/util/FileOperations.js 93.22% <100.00%> (-0.02%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0d65032...140d735. Read the comment docs.