adobe / aem-component-generator

AEM Component Generator is a java project that enables developers to generate the base structure of an AEM component using a JSON configuration file specifying component and dialog properties and other configuration options.
Apache License 2.0
113 stars 46 forks source link

Dialog radio button considered internal by OakPAL #50

Closed HitmanInWis closed 3 years ago

HitmanInWis commented 3 years ago

The component generator is creating radio buttons with sling:resourceType="granite/ui/components/coral/foundation/form/radio". However, OakPAL is flagging this as an error.

[ERROR]    +- <MAJOR> /apps/aem-activate/components/content/demo-comp/cq:dialog/content/items/tabs/items/tab-1/items/column/items/radioTest/items/radio1 [restricted resource type]: /libs/granite/ui/components/coral/foundation/form/radio is implicitly marked INTERNAL [aem-activate.ui.apps-5.1.0-SNAPSHOT.zip]
[ERROR]    +- <MAJOR> /apps/aem-activate/components/content/demo-comp/cq:dialog/content/items/tabs/items/tab-1/items/column/items/radioTest/items/radio2 [restricted resource type]: /libs/granite/ui/components/coral/foundation/form/radio is implicitly marked INTERNAL [aem-activate.ui.apps-5.1.0-SNAPSHOT.zip]
HitmanInWis commented 3 years ago

@adamcin ^^^

adamcin commented 3 years ago

sure enough, the radio resource type isn’t even available in cloud service sdk, and instead, radiogroup is there and explicitly marked granite:FinalArea , which allows for the usage that is failing in the build