SITES-22111 - Extend core CIF graphQL resolver with new function/API to expose Errors

LSantha commented 3 months ago

added getErrors() in AbstractRetriever
provided implementation for getErrors() in existing retrievers

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 82.81250% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 89.11%. Comparing base (c2356a0) to head (75d4ab4).

Files	Patch %	Lines
...rch/internal/services/SearchFilterServiceImpl.java	72.41%	4 Missing and 4 partials :warning:
.../commerce/core/search/models/SearchResultsSet.java	0.00%	1 Missing and 1 partial :warning:
...ch/internal/services/SearchResultsServiceImpl.java	87.50%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1006 +/- ## ============================================ - Coverage 89.13% 89.11% -0.02% - Complexity 2215 2226 +11 ============================================ Files 354 355 +1 Lines 10000 10039 +39 Branches 1440 1447 +7 ============================================ + Hits 8913 8946 +33 - Misses 789 790 +1 - Partials 298 303 +5 ``` | [Flag](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/1006/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/1006/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `51.81% <48.43%> (-0.01%)` | :arrow_down: | | [jest](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/1006/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `86.68% <ø> (ø)` | | | [karma](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/1006/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `95.54% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/1006/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `87.37% <82.81%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bradea-adobe commented 3 months ago

@LSantha pls also add Adi as reviewer thanks!

bradea-adobe commented 3 months ago

@ asilaghi

adobe / aem-core-cif-components