adobe / aem-core-cif-components

A set of configurations and components to get you started with AEM Commerce development
Apache License 2.0
102 stars 80 forks source link

SITES-22111 - Extend core CIF graphQL resolver with new function/API to expose Errors #1008

Closed LSantha closed 2 months ago

LSantha commented 2 months ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

bradea-adobe commented 2 months ago

@alwinjoseph02 @asilaghi pls see

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.11%. Comparing base (a4953d4) to head (0ab0ded).

Files Patch % Lines
...l/models/v1/productcarousel/ProductsRetriever.java 50.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1008 +/- ## ========================================= Coverage 89.11% 89.11% Complexity 2226 2226 ========================================= Files 355 355 Lines 10039 10042 +3 Branches 1447 1447 ========================================= + Hits 8946 8949 +3 Misses 790 790 Partials 303 303 ``` | [Flag](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/1008/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/1008/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `51.82% <40.00%> (+<0.01%)` | :arrow_up: | | [jest](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/1008/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `86.68% <ø> (ø)` | | | [karma](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/1008/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `95.54% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/1008/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `87.37% <80.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.