SITES-19938 - Build failure fix when project parent folder contains s…

bhavya-karodi commented 1 month ago

…pace

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.11%. Comparing base (2cdea98) to head (0c77f19).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1012 +/- ## ========================================= Coverage 89.11% 89.11% Complexity 2226 2226 ========================================= Files 355 355 Lines 10042 10042 Branches 1447 1447 ========================================= Hits 8949 8949 Misses 790 790 Partials 303 303 ``` | [Flag](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/1012/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/1012/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `51.82% <ø> (ø)` | | | [jest](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/1012/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `86.68% <ø> (ø)` | | | [karma](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/1012/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `95.54% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/1012/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `87.37% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

LSantha commented 1 month ago

@bhavya-karodi , I've pushed a small fix in the PR. Could you please run the test on a WIndows machine to see if it works?

adobe / aem-core-cif-components