adobe / aem-core-cif-components

A set of configurations and components to get you started with AEM Commerce development
Apache License 2.0
103 stars 80 forks source link

CIF-2612 - cloudManagerTarget config for examples deployment #777

Closed mhaack closed 2 years ago

mhaack commented 2 years ago

Description

Fix cloudManagerTarget config for CIF packages. Currently all CIF packages are ignores by CM, see below.

* commerce-cif-components/ui.apps/target/core-cif-components-apps-2.4.3-SNAPSHOT.zip (skipped-content-package)
* commerce-cif-components/extensions/product-recs/content/target/core-cif-components-extensions-product-recs-content-2.4.3-SNAPSHOT.zip (skipped-content-package)
* commerce-cif-components/examples/ui.content/target/core-cif-components-examples-content-2.4.3-SNAPSHOT.zip (skipped-content-package)
* commerce-cif-components/examples/ui.apps/target/core-cif-components-examples-apps-2.4.3-SNAPSHOT.zip (skipped-content-package)
* commerce-cif-components/examples/ui.config/target/core-cif-components-examples-config-2.4.3-SNAPSHOT.zip (skipped-content-package)
* commerce-cif-components/examples/all/target/core-cif-components-examples-all-2.4.3-SNAPSHOT.zip (skipped-content-package)
* commerce-cif-components/ui.config/target/core-cif-components-config-2.4.3-SNAPSHOT.zip (skipped-content-package)
* commerce-cif-components/all/target/core-cif-components-all-2.4.3-SNAPSHOT.zip (skipped-content-package)
* commerce-cif-components/it/content/target/core-cif-components-it-tests-content-2.4.3-SNAPSHOT.zip (skipped-content-package)

To get the examples deployment working we need the core-cif-components-all and all example packages deployed.

Related Issue

CIF-2612

648

Motivation and Context

Automatically deploy updated snapshot versions of CIF Core Components Library on aemcomponents.dev.

Types of changes

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #777 (4d607c4) into master (6ad7e37) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #777   +/-   ##
=========================================
  Coverage     89.24%   89.25%           
  Complexity     1773     1773           
=========================================
  Files           311      311           
  Lines          7999     8000    +1     
  Branches       1203     1203           
=========================================
+ Hits           7139     7140    +1     
  Misses          621      621           
  Partials        239      239           
Flag Coverage Δ
integration 57.68% <0.00%> (-0.13%) :arrow_down:
jest 86.29% <ø> (ø)
karma 94.83% <ø> (ø)
unittests 88.55% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ommerce/core/examples/servlets/GraphqlServlet.java 91.84% <100.00%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6ad7e37...4d607c4. Read the comment docs.

mhaack commented 2 years ago

https://github.com/adobe/aem-core-cif-components/pull/649 broke the automatic deployment since we also did exclude individual example packages from CM deployments.

mhaack commented 2 years ago

Please don't merge. I will merge once the CM build is working stable.