adobe / aem-core-cif-components

A set of configurations and components to get you started with AEM Commerce development
Apache License 2.0
103 stars 80 forks source link

CIF-2580: disable wish lists from store configuration #779

Closed buuhuu closed 2 years ago

buuhuu commented 2 years ago

Description

Wish lists can be enabled/disabled per store configuration. this information is available as part of the store config query. However as the configuration does not change often, it does not make much sense to query it for each page rendering that requires this information. Because of that we added a (feature) configuration to the CIF context aware configuration which can be automatically set from the store configuration with the next release of the CIF addon.

Related Issue

CIF-2580 CIF-2407

How Has This Been Tested?

Unit Tests, manual verifcation

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #779 (203439c) into master (50575df) will decrease coverage by 0.01%. The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #779      +/-   ##
============================================
- Coverage     89.23%   89.22%   -0.02%     
- Complexity     1763     1769       +6     
============================================
  Files           311      311              
  Lines          7991     7997       +6     
  Branches       1198     1204       +6     
============================================
+ Hits           7131     7135       +4     
  Misses          624      624              
- Partials        236      238       +2     
Flag Coverage Δ
integration 57.63% <22.22%> (-0.08%) :arrow_down:
jest 86.29% <ø> (ø)
karma 94.82% <ø> (ø)
unittests 88.51% <77.77%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onents/internal/models/v1/product/ProductImpl.java 87.42% <66.66%> (-0.44%) :arrow_down:
...nal/models/v1/productteaser/ProductTeaserImpl.java 87.17% <66.66%> (-0.98%) :arrow_down:
...ts/internal/models/v1/account/MiniAccountImpl.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 50575df...203439c. Read the comment docs.