adobe / aem-core-cif-components

A set of configurations and components to get you started with AEM Commerce development
Apache License 2.0
103 stars 80 forks source link

CIF-2235: Support different url formats for different store configurations #792

Closed laurentiumagureanu closed 2 years ago

laurentiumagureanu commented 2 years ago

Description

have a custom url format for a store, that is different from the other stores on the same deployment

Related Issue

CIF-2235

Motivation and Context

Different SEO needs for different stores

How Has This Been Tested?

unit test

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #792 (2d9cc04) into master (9b713fc) will decrease coverage by 0.11%. The diff coverage is 81.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #792      +/-   ##
============================================
- Coverage     89.54%   89.42%   -0.12%     
- Complexity     1842     1871      +29     
============================================
  Files           313      316       +3     
  Lines          8233     8322      +89     
  Branches       1241     1253      +12     
============================================
+ Hits           7372     7442      +70     
- Misses          621      629       +8     
- Partials        240      251      +11     
Flag Coverage Δ
integration 54.93% <37.50%> (-0.44%) :arrow_down:
jest 86.40% <ø> (ø)
karma 94.83% <ø> (ø)
unittests 88.85% <81.25%> (-0.19%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rce/core/components/services/urls/UrlProvider.java 100.00% <ø> (ø)
...vices/sitemap/SitemapLinkExternalizerProvider.java 86.66% <75.00%> (-0.84%) :arrow_down:
.../components/internal/services/UrlProviderImpl.java 83.73% <76.38%> (-4.40%) :arrow_down:
...nternal/servlets/ProductPageUrlFormatsServlet.java 80.00% <80.00%> (ø)
...ternal/servlets/CategoryPageUrlFormatsServlet.java 81.81% <81.81%> (ø)
...l/services/sitemap/CategoriesSitemapGenerator.java 80.59% <100.00%> (ø)
...nal/services/sitemap/ProductsSitemapGenerator.java 89.06% <100.00%> (ø)
...ternal/servlets/AbstractPageUrlFormatsServlet.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9b713fc...2d9cc04. Read the comment docs.