adobe / aem-core-cif-components

A set of configurations and components to get you started with AEM Commerce development
Apache License 2.0
103 stars 80 forks source link

CIF-2969: fix overlay handling in 6.5 #827

Closed buuhuu closed 2 years ago

buuhuu commented 2 years ago

Description

When implementing the overlay handling of the product recommendations component we introduced the usage of an API that is not available in 6.5 causing an error to be logged. This PR fixes that by using the API available in 6.5 instead.

Related Issue

CIF-2969 CIF-2240

Motivation and Context

How Has This Been Tested?

Locally

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #827 (6c42047) into master (a16e124) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #827   +/-   ##
=========================================
  Coverage     89.42%   89.42%           
  Complexity     1872     1872           
=========================================
  Files           316      316           
  Lines          8323     8323           
  Branches       1254     1254           
=========================================
  Hits           7443     7443           
  Misses          629      629           
  Partials        251      251           
Flag Coverage Δ
integration 54.94% <ø> (ø)
jest 86.40% <ø> (ø)
karma 94.83% <ø> (ø)
unittests 88.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a16e124...6c42047. Read the comment docs.