adobe / aem-core-cif-components

A set of configurations and components to get you started with AEM Commerce development
Apache License 2.0
103 stars 80 forks source link

CIF-2792: Always add SKU to product url format params #876

Closed buuhuu closed 2 years ago

buuhuu commented 2 years ago

Description

This change address a regression introduced with #776 after which the sku is not always available to product url formats.

Related Issue

776

875

CIF-2792

Motivation and Context

How Has This Been Tested?

Unit Tests

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #876 (80aa1d4) into master (af43e1d) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #876   +/-   ##
=========================================
  Coverage     69.43%   69.43%           
  Complexity     1164     1164           
=========================================
  Files           320      320           
  Lines          8497     8498    +1     
  Branches       1273     1273           
=========================================
+ Hits           5900     5901    +1     
  Misses         2183     2183           
  Partials        414      414           
Flag Coverage Δ
integration 54.99% <100.00%> (+<0.01%) :arrow_up:
jest 86.40% <ø> (ø)
karma 95.44% <ø> (ø)
unittests 90.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../components/internal/services/UrlProviderImpl.java 54.54% <100.00%> (+0.21%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update af43e1d...80aa1d4. Read the comment docs.