adobe / aem-core-cif-components

A set of configurations and components to get you started with AEM Commerce development
Apache License 2.0
103 stars 80 forks source link

CIF-2736 - Support custom sort keys in product listing components #901

Closed LSantha closed 2 years ago

LSantha commented 2 years ago

Related Issue

CIF-2736

How Has This Been Tested?

Manually, unit tests.

Screenshots (if appropriate):

image_2022-05-10_170730068

Types of changes

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #901 (3c7b441) into master (54be0f0) will decrease coverage by 0.70%. The diff coverage is 17.70%.

@@             Coverage Diff              @@
##             master     #901      +/-   ##
============================================
- Coverage     69.22%   68.52%   -0.71%     
  Complexity     1165     1165              
============================================
  Files           323      325       +2     
  Lines          8559     8622      +63     
  Branches       1278     1288      +10     
============================================
- Hits           5925     5908      -17     
- Misses         2220     2302      +82     
+ Partials        414      412       -2     
Flag Coverage Δ
integration 53.66% <17.70%> (-1.01%) :arrow_down:
jest 86.38% <ø> (ø)
karma 95.17% <ø> (ø)
unittests 90.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/models/productcollection/ProductCollection.java 0.00% <ø> (ø)
.../cq/commerce/core/search/models/SearchOptions.java 0.00% <0.00%> (ø)
...m/adobe/cq/commerce/core/search/models/Sorter.java 33.33% <0.00%> (-66.67%) :arrow_down:
...l/servlets/ProductSortFieldsDataSourceServlet.java 3.44% <3.44%> (ø)
...ch/internal/services/SearchResultsServiceImpl.java 59.14% <21.73%> (-11.50%) :arrow_down:
...core/search/internal/models/SearchOptionsImpl.java 86.27% <33.33%> (-7.06%) :arrow_down:
...nternal/models/v1/productlist/ProductListImpl.java 79.34% <40.00%> (-2.68%) :arrow_down:
...nal/models/v1/searchresults/SearchResultsImpl.java 90.00% <40.00%> (-10.00%) :arrow_down:
...mmerce/core/search/internal/models/SorterImpl.java 71.42% <0.00%> (-28.58%) :arrow_down:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 54be0f0...3c7b441. Read the comment docs.