adobe / aem-core-cif-components

A set of configurations and components to get you started with AEM Commerce development
Apache License 2.0
103 stars 80 forks source link

CIF-2732 - Teaser: add option to open CTA in a new Tab #909

Closed LSantha closed 2 years ago

LSantha commented 2 years ago

Related Issue

CIF-2732

How Has This Been Tested?

Manually, unit test.

Types of changes

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #909 (9ec18ec) into master (e25c271) will increase coverage by 0.06%. The diff coverage is 95.89%.

@@             Coverage Diff              @@
##             master     #909      +/-   ##
============================================
+ Coverage     89.41%   89.47%   +0.06%     
- Complexity     1951     1982      +31     
============================================
  Files           328      331       +3     
  Lines          8662     8808     +146     
  Branches       1293     1301       +8     
============================================
+ Hits           7745     7881     +136     
- Misses          652      660       +8     
- Partials        265      267       +2     
Flag Coverage Δ
integration 53.06% <82.50%> (-0.56%) :arrow_down:
jest 86.38% <ø> (ø)
karma 95.26% <95.45%> (+0.01%) :arrow_up:
unittests 88.81% <91.25%> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dels/v1/categorylist/FeaturedCategoryListImpl.java 90.76% <ø> (ø)
...models/v1/productcarousel/ProductCarouselBase.java 100.00% <ø> (ø)
...nal/models/v1/productteaser/ProductTeaserImpl.java 88.46% <ø> (ø)
...internal/models/v1/teaser/CategoriesRetriever.java 100.00% <ø> (ø)
...models/v1/teaser/CommerceTeaserActionItemImpl.java 76.92% <ø> (-15.39%) :arrow_down:
.../internal/models/v1/teaser/CommerceTeaserImpl.java 86.30% <ø> (ø)
.../internal/models/v2/teaser/CommerceTeaserImpl.java 91.66% <ø> (-4.17%) :arrow_down:
...ent/teaser/v3/teaser/clientlib/editor/js/teaser.js 95.45% <95.45%> (ø)
.../internal/models/v3/teaser/CommerceTeaserImpl.java 96.22% <96.22%> (ø)
...models/v3/teaser/CommerceTeaserActionItemImpl.java 96.29% <96.29%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e25c271...9ec18ec. Read the comment docs.

LSantha commented 2 years ago

I had to increase the aem-uber.jar dependency to 6.5.8 which contains ComponentStyleInfo.

LSantha commented 2 years ago

I've added deprecation information too.