adobe / aem-core-cif-components

A set of configurations and components to get you started with AEM Commerce development
Apache License 2.0
103 stars 80 forks source link

CIF-2827: Placeholder XF in product list component #930

Closed laurentiumagureanu closed 2 years ago

laurentiumagureanu commented 2 years ago

Description

be able to insert an XF into the product list component to show content between products

Related Issue

CIF-2827

Motivation and Context

be able to insert an XF into the product list component to show content between products

How Has This Been Tested?

Unit tests. Manually

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #930 (962f798) into master (daa88fa) will decrease coverage by 0.13%. The diff coverage is 76.73%.

@@             Coverage Diff              @@
##             master     #930      +/-   ##
============================================
- Coverage     89.71%   89.57%   -0.14%     
- Complexity     2154     2172      +18     
============================================
  Files           347      352       +5     
  Lines          9673     9764      +91     
  Branches       1394     1405      +11     
============================================
+ Hits           8678     8746      +68     
- Misses          713      727      +14     
- Partials        282      291       +9     
Flag Coverage Δ
integration 51.62% <27.50%> (-0.67%) :arrow_down:
jest 86.55% <ø> (ø)
karma 95.33% <100.00%> (+<0.01%) :arrow_up:
unittests 88.44% <73.00%> (-0.35%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ore/components/models/productlist/ProductList.java 50.00% <0.00%> (-50.00%) :arrow_down:
...ommerce/core/examples/servlets/GraphqlServlet.java 88.65% <0.00%> (-2.83%) :arrow_down:
...ents/CommerceExperienceFragmentsRetrieverImpl.java 65.38% <65.38%> (ø)
...servlets/ProductListXfStylesDataSourceServlet.java 70.00% <70.00%> (ø)
...nternal/servlets/AbstractProductListXfServlet.java 83.33% <83.33%> (ø)
...nternal/models/v1/productlist/ProductListImpl.java 92.20% <96.22%> (+1.00%) :arrow_up:
...gment/CommerceExperienceFragmentContainerImpl.java 100.00% <100.00%> (ø)
...riencefragment/CommerceExperienceFragmentImpl.java 90.90% <100.00%> (+15.41%) :arrow_up:
...ets/ProductListXfStylesRenderConditionServlet.java 100.00% <100.00%> (ø)
...oductcollection/clientlibs/js/productcollection.js 89.85% <100.00%> (+0.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update daa88fa...962f798. Read the comment docs.

LSantha commented 2 years ago

We may need an update for the readme and the examples project to show the cool new feature.