adobe / aem-core-cif-components

A set of configurations and components to get you started with AEM Commerce development
Apache License 2.0
103 stars 80 forks source link

CIF-2921: improve authoring experience of product v3 component #931

Closed buuhuu closed 2 years ago

buuhuu commented 2 years ago

Description

This change replaces the many checkboxes with a multi select and enables it in the component dialog as well as in the design dialog to ease the use of the feature.

Furthermore each section was extended with a per default hidden area title using the same markup as we have it already in place for some of the existing areas. This is in particular useful when a single section is show within the context of another component like a content fragment, where each element of the CF has a title and value.

Additionally:

Related Issue

CIF-2921

Motivation and Context

Simplify the configuration of composable commerce experience

How Has This Been Tested?

Unit tests and locally with wknd

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #931 (d991ccd) into master (c635a11) will decrease coverage by 0.00%. The diff coverage is 94.11%.

@@             Coverage Diff              @@
##             master     #931      +/-   ##
============================================
- Coverage     89.69%   89.68%   -0.01%     
- Complexity     2124     2125       +1     
============================================
  Files           343      343              
  Lines          9499     9502       +3     
  Branches       1367     1368       +1     
============================================
+ Hits           8520     8522       +2     
  Misses          700      700              
- Partials        279      280       +1     
Flag Coverage Δ
integration 52.35% <93.33%> (+<0.01%) :arrow_up:
jest 86.38% <100.00%> (ø)
karma 95.66% <ø> (ø)
unittests 88.74% <93.33%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onents/internal/models/v1/product/ProductImpl.java 86.59% <ø> (ø)
...nents/BundleProductOptions/bundleProductOptions.js 93.54% <ø> (ø)
...product/v3/product/clientlib/js/variantSelector.js 98.43% <ø> (ø)
...onents/internal/models/v3/product/ProductImpl.java 92.59% <93.33%> (-1.53%) :arrow_down:
.../src/components/GiftCardOptions/giftCardOptions.js 95.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c635a11...d991ccd. Read the comment docs.