CIF-2924: remove category_uid parameter in pagination when applicable

[buuhuu]

Description

The category_uid parameter got introduced when we switched from using the category id to uid in the product list. We removed it incrementally already in some places (applying facets, removing facets, facet navigation). With this change we removed it also from the pagination.

Related Issue

CIF-2924

Motivation and Context

The category_uid parameter is not necessary as for product lists the category_uid can always be obtained from the request url. Adding the parameter may affect the dispatcher cache ratio as it leads to different, eventually uncached urls for the same page.

How Has This Been Tested?

Unit tests, locally using Venia

Screenshots (if appropriate):

Types of changes

• [X] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [X] I have signed the Adobe Open Source CLA.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [X] I have read the CONTRIBUTING document.
• [X] I have added tests to cover my changes and the overall coverage did not decrease.
• [X] All unit tests pass on CircleCi.
• [X] I ran all tests locally and they pass.

[codecov[bot]]

Codecov Report

Merging #933 (31005d7) into master (f64c805) will decrease coverage by 0.01%. The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master     #933      +/-   ##
============================================
- Coverage     89.75%   89.73%   -0.02%     
+ Complexity     2020     2018       -2     
============================================
  Files           338      338              
  Lines          9281     9277       -4     
  Branches       1319     1318       -1     
============================================
- Hits           8330     8325       -5     
  Misses          678      678              
- Partials        273      274       +1     

Flag	Coverage Δ
integration	52.75% <75.00%> (-0.08%)	:arrow_down:
jest	86.38% <ø> (ø)
karma	95.66% <ø> (ø)
unittests	88.83% <75.00%> (-0.03%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ch/internal/services/SearchResultsServiceImpl.java	95.17% <75.00%> (-0.52%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f64c805...31005d7. Read the comment docs.