adobe / aem-core-cif-components

A set of configurations and components to get you started with AEM Commerce development
Apache License 2.0
103 stars 80 forks source link

CIF-2480: improve bundle product and gift card options #934

Closed buuhuu closed 2 years ago

buuhuu commented 2 years ago

Description

The change adds some minor improvements to the bundled products and gift card react components:

(1) requires a data-show-quantity attribute to be set to the mount point element. This has been newly introduced and would be a breaking change for customers that overwrite the productFullDetail.html. It was done that way in favour of negating the logic and fit the existing behaviour (e.g. data-hide-quantity) to have consistency with the other data attributes and to use a positive language.

Related Issue

CIF-2480

Motivation and Context

Improve the flexibility of the react components for composable product detail experiences

How Has This Been Tested?

Unit tests and locally using wknd+commerce

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #934 (5f3b3d5) into master (0ce0e30) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #934      +/-   ##
============================================
+ Coverage     89.68%   89.71%   +0.02%     
  Complexity     2125     2125              
============================================
  Files           343      343              
  Lines          9502     9517      +15     
  Branches       1368     1378      +10     
============================================
+ Hits           8522     8538      +16     
+ Misses          700      699       -1     
  Partials        280      280              
Flag Coverage Δ
integration 52.35% <ø> (ø)
jest 86.49% <100.00%> (+0.11%) :arrow_up:
karma 95.66% <ø> (ø)
unittests 88.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nents/BundleProductOptions/bundleProductOptions.js 95.28% <100.00%> (+1.73%) :arrow_up:
.../src/components/GiftCardOptions/giftCardOptions.js 96.15% <100.00%> (+0.32%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0ce0e30...5f3b3d5. Read the comment docs.