adobe / aem-core-cif-components

A set of configurations and components to get you started with AEM Commerce development
Apache License 2.0
103 stars 80 forks source link

CIF-2895 - Extend product retriever with hook for product filters #938

Closed herzog31 closed 2 years ago

herzog31 commented 2 years ago

Description

Requires a release of https://github.com/adobe/commerce-cif-magento-graphql/pull/29 before it can be merged.

Related Issue

See https://github.com/adobe/commerce-cif-magento-graphql/pull/27

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #938 (ccf15c9) into master (e1923ba) will increase coverage by 0.04%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #938      +/-   ##
============================================
+ Coverage     89.67%   89.72%   +0.04%     
- Complexity     2132     2148      +16     
============================================
  Files           346      346              
  Lines          9616     9660      +44     
  Branches       1385     1391       +6     
============================================
+ Hits           8623     8667      +44     
  Misses          712      712              
  Partials        281      281              
Flag Coverage Δ
integration 52.24% <46.66%> (-0.20%) :arrow_down:
jest 86.55% <ø> (ø)
karma 95.33% <ø> (ø)
unittests 88.80% <100.00%> (+0.08%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...l/models/v1/productcarousel/ProductsRetriever.java 94.36% <100.00%> (+0.71%) :arrow_up:
...s/v1/relatedproducts/RelatedProductsRetriever.java 96.42% <100.00%> (+0.35%) :arrow_up:
.../models/retriever/AbstractCategoriesRetriever.java 100.00% <100.00%> (ø)
...ts/models/retriever/AbstractCategoryRetriever.java 89.09% <100.00%> (+1.85%) :arrow_up:
...nts/models/retriever/AbstractProductRetriever.java 100.00% <100.00%> (ø)
...ts/models/retriever/AbstractProductsRetriever.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e1923ba...ccf15c9. Read the comment docs.