adobe / aem-core-cif-components

A set of configurations and components to get you started with AEM Commerce development
Apache License 2.0
103 stars 80 forks source link

CIF-2537 - Make Associated Content Service public #945

Closed LSantha closed 2 years ago

LSantha commented 2 years ago

Using Associated Content Service in commere content fragment and commerce experience fragment component.

Related Issue

CIF-2537

How Has This Been Tested?

Manually, JUnit.

Types of changes

Checklist:

LSantha commented 2 years ago

The failures are caused by the missing new add-on dependency which should be released.

LSantha commented 2 years ago

I'll resolve the conflicts soon ...

codecov[bot] commented 2 years ago

Codecov Report

Merging #945 (a27ad70) into master (dc2eae4) will increase coverage by 0.07%. The diff coverage is 98.07%.

@@             Coverage Diff              @@
##             master     #945      +/-   ##
============================================
+ Coverage     89.37%   89.45%   +0.07%     
+ Complexity     2187     2182       -5     
============================================
  Files           350      350              
  Lines          9828     9803      -25     
  Branches       1414     1410       -4     
============================================
- Hits           8784     8769      -15     
+ Misses          745      739       -6     
+ Partials        299      295       -4     
Flag Coverage Δ
integration 51.89% <44.23%> (-0.11%) :arrow_down:
jest 86.55% <ø> (ø)
karma 95.33% <ø> (ø)
unittests 88.09% <94.23%> (+0.10%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...1/contentfragment/CommerceContentFragmentImpl.java 86.51% <94.44%> (+3.02%) :arrow_up:
...nternal/models/v1/productlist/ProductListImpl.java 89.01% <100.00%> (-0.07%) :arrow_down:
...ents/CommerceExperienceFragmentsRetrieverImpl.java 67.64% <100.00%> (+2.26%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more