search

adobe / aem-core-cif-components

A set of configurations and components to get you started with AEM Commerce development
Apache License 2.0
103 stars 80 forks source link

Code smells in CIF code #947

Open pithayx opened 2 years ago

pithayx commented 2 years ago

Expected Behavior - No Code Smells in AEMaaCS code scan.

Actual Behavior - Getting following code smell in the scan report -

cif-components-library:core-cif-components-all:2.0.0: Inclusion of both /etc/packages/adobe/aem650/core-cif-components-apps-2.0.0.zip/jcr:content and /apps/core in the same package violates the separation of immutable and mutable paths in the same package. : ImmutableMutableMixedPackage : https://www.adobe.com/go/aem_cmcq_immutablemutablemixe_en

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Platform and Version: AEMaaCS 2022.7.8085.20220725T140323Z, CIF version :2.0.0

Sample Code that illustrates the problem

Logs taken while reproducing problem

buuhuu commented 1 year ago

Hey @pithayx, can you please add steps to reproduce this issue?

Did you try to add the CIF sources to your cloud manager project? If so this is usually not the recommended approach. We provide binary distribution packages of CIF that you can embed as dependencies into your project.

pithayx commented 1 year ago

@Buuhuu We have embeded the package as dependency in our project. This error is reported when the code is deployed as a part of AEMaaCS Cloud Manager pipelines in the code scan report.