adobe / aem-core-cif-components

A set of configurations and components to get you started with AEM Commerce development
Apache License 2.0
103 stars 80 forks source link

Add missing Experience Platform Connector events to Core Components #949

Closed laurentiumagureanu closed 1 year ago

laurentiumagureanu commented 2 years ago

Description

Add necessary context and data for add to cart storefront event.

For Product Carousel, Product List, Product Teaser:

For Product:

For Search:

In general

Related Issue

CIF-2898

Motivation and Context

enables Beacon tracking

How Has This Been Tested?

Unit test

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #949 (181aadb) into master (2dd2b2c) will increase coverage by 0.02%. The diff coverage is 96.50%.

@@             Coverage Diff              @@
##             master     #949      +/-   ##
============================================
+ Coverage     89.46%   89.49%   +0.02%     
- Complexity     2204     2211       +7     
============================================
  Files           351      354       +3     
  Lines          9857     9967     +110     
  Branches       1422     1436      +14     
============================================
+ Hits           8819     8920     +101     
- Misses          742      750       +8     
- Partials        296      297       +1     
Flag Coverage Δ
integration 52.22% <43.75%> (+0.04%) :arrow_up:
jest 86.68% <100.00%> (+0.13%) :arrow_up:
karma 95.53% <100.00%> (+0.20%) :arrow_up:
unittests 88.00% <81.25%> (-0.14%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ommerce/core/components/datalayer/ProductData.java 0.00% <0.00%> (ø)
...internal/models/v1/common/ProductListItemImpl.java 95.09% <0.00%> (-0.95%) :arrow_down:
...erce/core/components/models/product/GroupItem.java 0.00% <0.00%> (ø)
...ts/storefrontcontext/ProductStorefrontContext.java 0.00% <0.00%> (ø)
...torefrontcontext/ProductStorefrontContextImpl.java 90.00% <75.00%> (-10.00%) :arrow_down:
...ponents/internal/datalayer/DataLayerComponent.java 80.95% <100.00%> (+0.46%) :arrow_up:
...components/internal/datalayer/ProductDataImpl.java 100.00% <100.00%> (ø)
...ents/internal/models/v1/product/GroupItemImpl.java 100.00% <100.00%> (ø)
...onents/internal/models/v1/product/ProductImpl.java 87.55% <100.00%> (+0.05%) :arrow_up:
...nal/models/v1/productteaser/ProductTeaserImpl.java 90.66% <100.00%> (+0.12%) :arrow_up:
... and 18 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more