search

adobe / aem-core-cif-components

A set of configurations and components to get you started with AEM Commerce development
Apache License 2.0
102 stars 80 forks source link

fix: graphql version conflict with peregrine 12 #962

Closed buuhuu closed 1 year ago

buuhuu commented 1 year ago

The graphql dependency chain cannot be satisfied with the Core CIF React Components. This is happens subscriptions-transport-ws@0.11.0 requires at least graphql@15.7.0 but the @adobe/aem-core-cif-react-components limit it to ~15.3.0.

Since https://github.com/adobe/aem-project-archetype/pull/990 the new peer dependency handling became the default, so we should fix this.

Bumping the peer dependency from ~15.3.0 to ~15.7.2.

npm ERR! Found: graphql@16.6.0
npm ERR! node_modules/graphql
npm ERR!   peer graphql@">=0.11 <=16" from graphql-ws@5.11.2
npm ERR!   node_modules/graphql-ws
npm ERR!     peerOptional graphql-ws@"^5.5.5" from @apollo/client@3.5.10
npm ERR!     node_modules/@apollo/client
npm ERR!       peer @apollo/client@"^3.1.2" from @adobe/aem-core-cif-react-components@2.11.0
npm ERR!       node_modules/@adobe/aem-core-cif-react-components
npm ERR!         @adobe/aem-core-cif-react-components@"*" from the root project
npm ERR!       1 more (@magento/peregrine)
npm ERR!   peer graphql@"^15.7.2 || ^16.0.0" from subscriptions-transport-ws@0.11.0
npm ERR!   node_modules/subscriptions-transport-ws
npm ERR!     peerOptional subscriptions-transport-ws@"^0.9.0 || ^0.11.0" from @apollo/client@3.5.10
npm ERR!     node_modules/@apollo/client
npm ERR!       peer @apollo/client@"^3.1.2" from @adobe/aem-core-cif-react-components@2.11.0
npm ERR!       node_modules/@adobe/aem-core-cif-react-components
npm ERR!         @adobe/aem-core-cif-react-components@"*" from the root project
npm ERR!       1 more (@magento/peregrine)
npm ERR!   1 more (@apollo/client)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer graphql@"~15.3.0" from @adobe/aem-core-cif-react-components@2.11.0
npm ERR! node_modules/@adobe/aem-core-cif-react-components
npm ERR!   @adobe/aem-core-cif-react-components@"*" from the root project
codecov[bot] commented 1 year ago

Codecov Report

Merging #962 (6822dcf) into master (03ff890) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #962   +/-   ##
=========================================
  Coverage     89.14%   89.14%           
  Complexity     2208     2208           
=========================================
  Files           354      354           
  Lines          9980     9980           
  Branches       1437     1437           
=========================================
  Hits           8897     8897           
  Misses          787      787           
  Partials        296      296
Flag Coverage Δ
integration 51.84% <ø> (ø)
jest 86.68% <ø> (ø)
karma 95.53% <ø> (ø)
unittests 87.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more