adobe / aem-core-cif-components

A set of configurations and components to get you started with AEM Commerce development
Apache License 2.0
102 stars 80 forks source link

fix: add Page v3 resource type to CatalogPageNotFoundFilter and redirect servlets #989

Closed buuhuu closed 8 months ago

buuhuu commented 10 months ago

Description

Some of the servlets and filters are not yet registered for the Page v3 resource type. The functionality provided by them is missing.

Related Issue

987

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (77d2b0b) 89.12% compared to head (fdd0742) 89.12%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #989 +/- ## ========================================= Coverage 89.12% 89.12% Complexity 2215 2215 ========================================= Files 354 354 Lines 9999 9999 Branches 1440 1440 ========================================= Hits 8912 8912 Misses 789 789 Partials 298 298 ``` | [Flag](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/989/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/989/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `51.81% <ø> (ø)` | | | [jest](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/989/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `86.68% <ø> (ø)` | | | [karma](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/989/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `95.53% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/989/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `87.38% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.