Aep extension fixes - Githubissues

aniham commented 10 months ago

upgrade to latest version of collector
generate search results view event
remove context from search events (should be picked up from data layer)
return facets as list instead of null (schema validation failures)

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (19ed842) 89.12% compared to head (f66b9d5) 89.12%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #991 +/- ## ========================================= Coverage 89.12% 89.12% Complexity 2215 2215 ========================================= Files 354 354 Lines 9999 9999 Branches 1440 1440 ========================================= Hits 8912 8912 Misses 789 789 Partials 298 298 ``` | [Flag](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/991/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/991/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `51.81% <0.00%> (ø)` | | | [jest](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/991/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `86.68% <ø> (ø)` | | | [karma](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/991/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `95.53% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/adobe/aem-core-cif-components/pull/991/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `87.38% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

LSantha commented 8 months ago

@aniham , could you please create a JIRA ticket for this and add verification instructions too? We are preparing a new release two weeks from now.

aniham commented 8 months ago

hi @LSantha the ticket is https://jira.corp.adobe.com/browse/MSRCH-3746

misha-kotov commented 8 months ago

Related JIRA ticket in AEM SITES project: https://jira.corp.adobe.com/browse/SITES-17751

misha-kotov commented 8 months ago

Validation steps:

Setup live search or product recommendations on a AEM instance
Setup the AEP extension
Generate an event for each type AEP Extension supports (ex: fire an AddToCart event by doing the action on the storefront)
https://wiki.corp.adobe.com/pages/viewpage.action?spaceKey=CENG&title=Empty+OR+missing+statistics+for+recommendations -- Ensure all event types supported by AEP Extension are ending up in the "Good bucket"
Check that the live search dashboard and PREX dashboard are populating with metrics

adobe / aem-core-cif-components

Aep extension fixes #991

Codecov Report