adobe / aem-core-cif-components

A set of configurations and components to get you started with AEM Commerce development
Apache License 2.0
102 stars 80 forks source link

SITES-17412: Log WARN when getting duplicate id from Magento GraphQL API #994

Closed hrayrpapikyan closed 8 months ago

hrayrpapikyan commented 9 months ago

Log WARN when getting duplicate id from Magento GraphQL API

Description

Log WARN when getting duplicate id from Magento GraphQL API

Related Issue

https://jira.corp.adobe.com/browse/SITES-17412

Motivation and Context

There exists a way to get duplicate data from Magento GraphQL API, this possibility occurs when customers add data to their system and the indexers do not complete before data is retrieved from the system.

Do It Best was affected by this and the AEM Support Org spent weeks debugging (because it was also a very intermittent issue). Eventually, T3 deployed a custom build of the Category Feature List showcasing the GraphQL query and we discovered that the categoryIds were unique. After engaging and reviewing our findings with SITES engineering we agreed to log a ticket with Magneto Engineering which then Magento ack'd that this can occur.

The CIF should log a WARN in the logs to help inform the customer that they need to fix the data in their Magento instance so that their site is not showcasing incorrect data.

In the situation where the customer has [^components .content.doitbest.us.en.global.homepage.jcr-content.root.json] we should check that the resulting GraphQL response does not contain duplicate categoryId or else this would be an issue.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

LSantha commented 8 months ago

@hrayrpapikyan , need to check the tests! The codecov check would usually fail for this PR because the new code doesn't have any coverage.