Devtomaster 3 may - Githubissues

adobe / aem-core-forms-components

Standardized components to build forms with AEM Forms

Apache License 2.0

26 stars 59 forks source link

Devtomaster 3 may #1217

Closed barshat7 closed 5 months ago

barshat7 commented 5 months ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

adobe-bot commented 5 months ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	100	75

adobe-bot commented 5 months ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	96	100	75

adobe-bot commented 5 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot commented 5 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot commented 5 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot commented 5 months ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	100	75

adobe-bot commented 5 months ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	94	96	100	75

adobe-bot commented 5 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot commented 5 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot commented 5 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 85.29412% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 80.89%. Comparing base (395f306) to head (aa543a3).

Files	Patch %	Lines
...mponents/internal/models/v1/form/HCaptchaImpl.java	82.60%	1 Missing and 3 partials :warning:
...core/components/util/AbstractOptionsFieldImpl.java	90.90%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1217 +/- ## ============================================ + Coverage 80.81% 80.89% +0.08% - Complexity 782 791 +9 ============================================ Files 91 92 +1 Lines 2116 2146 +30 Branches 286 292 +6 ============================================ + Hits 1710 1736 +26 - Misses 252 253 +1 - Partials 154 157 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.