search

adobe / aem-core-forms-components

Apache License 2.0
26 stars 50 forks source link

custom function edge delivery integration #1223

Closed deepprakash345 closed 3 months ago

adobe-bot commented 3 months ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 98 96 96 75
adobe-bot commented 3 months ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.30%. Comparing base (2b0116c) to head (e01dc88).

Files Patch % Lines
...s/internal/form/FormConfigurationProviderImpl.java 85.71% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1223 +/- ## ============================================ + Coverage 81.27% 81.30% +0.02% - Complexity 807 812 +5 ============================================ Files 93 94 +1 Lines 2168 2182 +14 Branches 294 298 +4 ============================================ + Hits 1762 1774 +12 Misses 252 252 - Partials 154 156 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rismehta commented 3 months ago

the patch coverage is less, please fix the coverage

adobe-bot commented 3 months ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75
adobe-bot commented 3 months ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 98 96 96 75
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75
adobe-bot commented 3 months ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 98 96 96 75
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 98 96 96 75
adobe-bot commented 3 months ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
deepprakash345 commented 3 months ago

@deepprakash345 , is it possible to move all custom function edge delivery collateral and tests in a folder under 'ruleeditor' folder? We are planning to run rule editor tests in rule editor pipelines as well and would like to keep all rule editor specific tests under single folder.

@arunattri26 , the custom function tests are of runtime, lets discuss this over a call, we are not testing any rule editor releated functionality in these tests

adobe-bot commented 3 months ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 98 96 96 75
adobe-bot commented 3 months ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 94 96 100 75
adobe-bot commented 3 months ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 89 96 100 75
adobe-bot commented 3 months ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 93 96 100 75
adobe-bot commented 3 months ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
deepprakash345 commented 3 months ago

the patch coverage is less, please fix the coverage

Screenshot 2024-05-21 at 9 40 47 AM

@rismehta , as seen in the screenshot of the codecov, all the branches of the code are covered, its showing the ifs as partial lines.

jalagari commented 3 months ago

the patch coverage is less, please fix the coverage

Screenshot 2024-05-21 at 9 40 47 AM

@rismehta , as seen in the screenshot of the codecov, all the branches of the code are covered, its showing the ifs as partial lines.

@deepprakash345 - Can we add unit test cases for missing cases?

adobe-bot commented 3 months ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 92 96 100 75
adobe-bot commented 3 months ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
deepprakash345 commented 3 months ago

Are the FT present in the test case, dependent on the feature which is part of this PR ? If not, please remove these from the CL

removed

deepprakash345 commented 3 months ago

the patch coverage is less, please fix the coverage

Screenshot 2024-05-21 at 9 40 47 AM

@rismehta , as seen in the screenshot of the codecov, all the branches of the code are covered, its showing the ifs as partial lines.

@deepprakash345 - Can we add unit test cases for missing cases?

added UTs , coverage check passed.