Closed deepprakash345 closed 3 months ago
Performance | Accessibility | Best-Practices | SEO | |
---|---|---|---|---|
Scores | 100 | 96 | 96 | 75 |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
Attention: Patch coverage is 85.71429%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 81.30%. Comparing base (
2b0116c
) to head (e01dc88
).
Files | Patch % | Lines |
---|---|---|
...s/internal/form/FormConfigurationProviderImpl.java | 85.71% | 0 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
the patch coverage is less, please fix the coverage
Performance | Accessibility | Best-Practices | SEO | |
---|---|---|---|---|
Scores | 100 | 96 | 96 | 75 |
Performance | Accessibility | Best-Practices | SEO | |
---|---|---|---|---|
Scores | 98 | 96 | 96 | 75 |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
Performance | Accessibility | Best-Practices | SEO | |
---|---|---|---|---|
Scores | 100 | 96 | 96 | 75 |
Performance | Accessibility | Best-Practices | SEO | |
---|---|---|---|---|
Scores | 98 | 96 | 96 | 75 |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
Performance | Accessibility | Best-Practices | SEO | |
---|---|---|---|---|
Scores | 98 | 96 | 96 | 75 |
Performance | Accessibility | Best-Practices | SEO | |
---|---|---|---|---|
Scores | 100 | 96 | 96 | 75 |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
@deepprakash345 , is it possible to move all custom function edge delivery collateral and tests in a folder under 'ruleeditor' folder? We are planning to run rule editor tests in rule editor pipelines as well and would like to keep all rule editor specific tests under single folder.
@arunattri26 , the custom function tests are of runtime, lets discuss this over a call, we are not testing any rule editor releated functionality in these tests
Performance | Accessibility | Best-Practices | SEO | |
---|---|---|---|---|
Scores | 98 | 96 | 96 | 75 |
Performance | Accessibility | Best-Practices | SEO | |
---|---|---|---|---|
Scores | 100 | 96 | 96 | 75 |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
Performance | Accessibility | Best-Practices | SEO | |
---|---|---|---|---|
Scores | 94 | 96 | 100 | 75 |
Performance | Accessibility | Best-Practices | SEO | |
---|---|---|---|---|
Scores | 100 | 96 | 100 | 75 |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
Performance | Accessibility | Best-Practices | SEO | |
---|---|---|---|---|
Scores | 89 | 96 | 100 | 75 |
Performance | Accessibility | Best-Practices | SEO | |
---|---|---|---|---|
Scores | 100 | 96 | 100 | 75 |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
Performance | Accessibility | Best-Practices | SEO | |
---|---|---|---|---|
Scores | 93 | 96 | 100 | 75 |
Performance | Accessibility | Best-Practices | SEO | |
---|---|---|---|---|
Scores | 100 | 96 | 100 | 75 |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
the patch coverage is less, please fix the coverage
@rismehta , as seen in the screenshot of the codecov, all the branches of the code are covered, its showing the ifs as partial lines.
the patch coverage is less, please fix the coverage
![]()
@rismehta , as seen in the screenshot of the codecov, all the branches of the code are covered, its showing the ifs as partial lines.
@deepprakash345 - Can we add unit test cases for missing cases?
Performance | Accessibility | Best-Practices | SEO | |
---|---|---|---|---|
Scores | 92 | 96 | 100 | 75 |
Performance | Accessibility | Best-Practices | SEO | |
---|---|---|---|---|
Scores | 100 | 96 | 100 | 75 |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
Id | Impact |
---|---|
label-title-only | serious |
landmark-one-main | moderate |
region | moderate |
target-size | serious |
Are the FT present in the test case, dependent on the feature which is part of this PR ? If not, please remove these from the CL
removed
the patch coverage is less, please fix the coverage
![]()
@rismehta , as seen in the screenshot of the codecov, all the branches of the code are covered, its showing the ifs as partial lines.
@deepprakash345 - Can we add unit test cases for missing cases?
added UTs , coverage check passed.
Lighthouse scores (mobile)