adobe / aem-core-forms-components

Apache License 2.0
26 stars 50 forks source link

[WiP] FORMS-14059 | Adding rendition for Turnstile #1224

Closed navneet-ag closed 3 months ago

navneet-ag commented 3 months ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

adobe-bot commented 3 months ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75
adobe-bot commented 3 months ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 94 96 100 75
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.28%. Comparing base (19ad077) to head (d296432).

:exclamation: Current head d296432 differs from pull request most recent head a4b9210. Consider uploading reports for the commit a4b9210 to get more accurate results

Files Patch % Lines
...ponents/internal/models/v1/form/TurnstileImpl.java 83.33% 1 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1224 +/- ## ============================================ + Coverage 81.27% 81.28% +0.01% - Complexity 807 811 +4 ============================================ Files 93 94 +1 Lines 2168 2191 +23 Branches 294 297 +3 ============================================ + Hits 1762 1781 +19 - Misses 252 253 +1 - Partials 154 157 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adobe-bot commented 3 months ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 94 96 100 75
adobe-bot commented 3 months ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75
adobe-bot commented 3 months ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 93 96 100 75
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious