FORMS-14419 Fix adding items in loop

adobe / aem-core-forms-components

Apache License 2.0

26 stars 50 forks source link

FORMS-14419 Fix adding items in loop #1234

Closed dmaurya929 closed 1 month ago

dmaurya929 commented 3 months ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

dmaurya929 commented 3 months ago

@sakshi-arora1 please review this change, if looks good I'll add test

adobe-bot commented 3 months ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	100	75

adobe-bot commented 3 months ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	96	100	75

adobe-bot commented 3 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot commented 3 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

dmaurya929 commented 2 months ago

@sakshi-arora1 build is failing for this PR, I haven't made any changes in the bundle but it is asking to increase the package version. Please help me to understand

[INFO]   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
[INFO] = ================================================== ========== ========== ========== ========== ==========
[INFO] * com.adobe.cq.forms.core.components.models.aemform  major      1.4.0      1.5.0      2.0.0      Version increase required

[ERROR] Failed to execute goal org.apache.felix:maven-bundle-plugin:5.1.4:baseline (baseline) on project core-forms-components-core: Baseline failed, see generated report -> [Help 1]