FORMS-14461 Reset resets static text. - Githubissues

adobe / aem-core-forms-components

Apache License 2.0

26 stars 50 forks source link

FORMS-14461 Reset resets static text. #1239

Closed sakshi-arora1 closed 3 months ago

sakshi-arora1 commented 3 months ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

rismehta commented 3 months ago

Can you fix the java 11 build ?

adobe-bot commented 3 months ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	94	96	100	75

adobe-bot commented 3 months ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	100	75

adobe-bot commented 3 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot commented 3 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot commented 3 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.32%. Comparing base (74e7d4c) to head (acc36ed).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #1239 +/- ## ============================================ + Coverage 81.30% 81.32% +0.02% - Complexity 812 813 +1 ============================================ Files 94 94 Lines 2182 2185 +3 Branches 298 298 ============================================ + Hits 1774 1777 +3 Misses 252 252 Partials 156 156 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.