adobe / aem-core-forms-components

Apache License 2.0
26 stars 50 forks source link

Revert "FORMS-13981 - Encode formDefinition with jsonString context" #1241

Closed TalmizAhmed closed 3 months ago

TalmizAhmed commented 3 months ago

Reverts adobe/aem-core-forms-components#1236

nit23uec commented 3 months ago

this change is dependent on the latest unreleased QS. The PR will be merged only when we have the public release of QS.

TalmizAhmed commented 3 months ago

Reason for revert: This change is dependant on the latest quickstart, which has not been publicly released yet, and therefore would cause breaking changes in EDS rendered forms, I will re-raise this PR once the latest quickstart having the updated sightly version is available.

adobe-bot commented 3 months ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 94 96 100 75
adobe-bot commented 3 months ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.27%. Comparing base (f59b405) to head (8df8560).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1241 +/- ## ========================================= Coverage 81.27% 81.27% Complexity 807 807 ========================================= Files 93 93 Lines 2168 2168 Branches 294 294 ========================================= Hits 1762 1762 Misses 252 252 Partials 154 154 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TalmizAhmed commented 3 months ago

New PR for ref: https://github.com/adobe/aem-core-forms-components/pull/1242