Encode formDefinition with jsonString context

TalmizAhmed commented 6 months ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.41%. Comparing base (e0481b5) to head (a156b7b).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #1242 +/- ## ========================================= Coverage 81.41% 81.41% Complexity 818 818 ========================================= Files 94 94 Lines 2201 2201 Branches 301 301 ========================================= Hits 1792 1792 Misses 252 252 Partials 157 157 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adobe-bot commented 6 months ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	100	75

adobe-bot commented 6 months ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	96	100	75

adobe-bot commented 6 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot commented 6 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot commented 6 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot commented 6 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

TalmizAhmed commented 6 months ago

Support for jsonString context is now available in public AEM cloud release Release 16357 cc: @rismehta

rismehta commented 6 months ago

Support for jsonString context is now available in public AEM cloud release Release 16357 cc: @rismehta

What is the behavior of the code if context is not available ? Is the rendering blocked

TalmizAhmed commented 6 months ago

@rismehta No the rendering would just be in the default context of the html tag, without the encoding provided by jsonString

TalmizAhmed commented 6 months ago

@rismehta This test case will be improved by @deepprakash345 to include checks for this use case too and is being tracked by a separate ticket (FORMS-14628)