UE: Supporting custom viewType in sling models - Githubissues

adobe / aem-core-forms-components

Apache License 2.0

26 stars 50 forks source link

UE: Supporting custom viewType in sling models #1247

Closed TalmizAhmed closed 3 months ago

TalmizAhmed commented 3 months ago

Description

This is a UE usecase, to override :type of the json by providing fd:viewType property in the jcr node of any component.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

adobe-bot commented 3 months ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	100	75

adobe-bot commented 3 months ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	94	96	100	75

adobe-bot commented 3 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot commented 3 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot commented 3 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot commented 3 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.39%. Comparing base (c3151cd) to head (4f4d362).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #1247 +/- ## ============================================ + Coverage 81.37% 81.39% +0.01% - Complexity 816 817 +1 ============================================ Files 94 94 Lines 2191 2193 +2 Branches 300 300 ============================================ + Hits 1783 1785 +2 Misses 252 252 Partials 156 156 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.