FORMS-14545 Adding custom submit test behind FT

adobe / aem-core-forms-components

Apache License 2.0

26 stars 50 forks source link

FORMS-14545 Adding custom submit test behind FT #1251

Closed rismehta closed 2 months ago

rismehta commented 2 months ago

@review @vdua DOD(yes)

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

adobe-bot commented 2 months ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	100	75

adobe-bot commented 2 months ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	100	75

adobe-bot commented 2 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot commented 2 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot commented 2 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.39%. Comparing base (a22e04a) to head (a566a1a).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #1251 +/- ## ========================================= Coverage 81.39% 81.39% Complexity 817 817 ========================================= Files 94 94 Lines 2193 2193 Branches 300 300 ========================================= Hits 1785 1785 Misses 252 252 Partials 156 156 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rismehta commented 2 months ago

This PR passed because in old addon this code was behind "FT_FORMS-8965" FT