search

adobe / aem-core-forms-components

Apache License 2.0
25 stars 49 forks source link

Dev to master 28may #1253

Closed deepprakash345 closed 1 month ago

deepprakash345 commented 1 month ago

The following 3 files had conflicts in it. Have kept the updated changes from dev branch while resolving the conflict

1..circleci/docker-compose.yml
2.parent/pom.xml 3.ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/datepicker/v1/datepicker/clientlibs/site/js/datepickerwidget.js

adobe-bot commented 1 month ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 93 96 100 75
adobe-bot commented 1 month ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75
adobe-bot commented 1 month ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 1 month ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
deepprakash345 commented 1 month ago

Please fix wizard.locale.spec.js, other changes are fine

Done

adobe-bot commented 1 month ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75
adobe-bot commented 1 month ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 94 96 100 75
adobe-bot commented 1 month ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 1 month ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 1 month ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 1 month ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75
adobe-bot commented 1 month ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 93 96 100 75
adobe-bot commented 1 month ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.39%. Comparing base (15bcd3a) to head (bbf8271).

Files Patch % Lines
...s/internal/form/FormConfigurationProviderImpl.java 85.71% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1253 +/- ## ============================================ + Coverage 81.27% 81.39% +0.12% - Complexity 807 817 +10 ============================================ Files 93 94 +1 Lines 2168 2193 +25 Branches 294 300 +6 ============================================ + Hits 1762 1785 +23 Misses 252 252 - Partials 154 156 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.