adobe / aem-core-forms-components

Standardized components to build forms with AEM Forms
Apache License 2.0
26 stars 58 forks source link

FORMS-14580 | Retiring FT-FORMS-8771 #1258

Closed navneet-ag closed 5 months ago

navneet-ag commented 5 months ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.41%. Comparing base (e24b83f) to head (2d68a6e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1258 +/- ## ========================================= Coverage 81.41% 81.41% Complexity 818 818 ========================================= Files 94 94 Lines 2201 2201 Branches 301 301 ========================================= Hits 1792 1792 Misses 252 252 Partials 157 157 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adobe-bot commented 5 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 5 months ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 93 96 100 75
adobe-bot commented 5 months ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75
adobe-bot commented 5 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 5 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
navneet-ag commented 5 months ago

Can you remove FT from the static toggle provider configuration ?

@rismehta I could not find the usage of this FT anywhere else in the repo. I also checked https://github.com/adobe/aem-core-forms-components/blob/master/it/config/src/main/content/jcr_root/apps/system/config/com.adobe.granite.toggle.impl.dev.DynamicToggleProviderImpl.cfg.json could not find the usage here.

Is static toggle provider configuration listed somewhere else ?

rismehta commented 5 months ago

Is static toggle provider configuration listed somewhere else ?

Was this FT enabled as part of the static FT configuration which exist in the product itself ?

navneet-ag commented 5 months ago

Yes this FT was enabled as a part of product as is already GA.