few properties were not getting updated via rules on form initialization

barshat7 commented 4 weeks ago

Description

Some Properties like 'required' 'description' and 'label' were not getting updated when set via rule 'When Form is Initialized'. Further, the 'description' was never getting updated as if no description was authored initially then the description div was explicitly ignored in the Sightly. As a fix, included the long description div (which is always hidden by default until question mark icon is clicked), and marked the questionMark div as hidden unless we see that the description is present.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

adobe-bot commented 3 weeks ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	89	96	100	75

adobe-bot commented 3 weeks ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	100	75

adobe-bot commented 3 weeks ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

rismehta commented 2 weeks ago

Also, do we have a customer who has asked for this change ? Can you link the JIRA in the PR

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.58%. Comparing base (c226e52) to head (2146629).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #1274 +/- ## ========================================= Coverage 81.58% 81.58% Complexity 847 847 ========================================= Files 96 96 Lines 2259 2259 Branches 306 306 ========================================= Hits 1843 1843 Misses 257 257 Partials 159 159 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.