FORMS-14468 | Updating Captcha interface and it's implementation

navneet-ag commented 3 weeks ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

adobe-bot commented 3 weeks ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 3 weeks ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	96	100	75

adobe-bot commented 3 weeks ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	100	75

adobe-bot commented 3 weeks ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 3 weeks ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 94.38202% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.06%. Comparing base (6419fbb) to head (5637725).

Files	Patch %	Lines
...nents/internal/models/v2/form/RecaptchaImplV2.java	94.28%	0 Missing and 2 partials :warning:
...mponents/internal/models/v1/form/HCaptchaImpl.java	85.71%	1 Missing :warning:
...ponents/internal/models/v1/form/RecaptchaImpl.java	85.71%	0 Missing and 1 partial :warning:
...onents/internal/models/v2/form/HCaptchaImplV2.java	96.77%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #1281 +/- ## ============================================ + Coverage 81.54% 82.06% +0.51% - Complexity 828 859 +31 ============================================ Files 95 97 +2 Lines 2222 2297 +75 Branches 303 315 +12 ============================================ + Hits 1812 1885 +73 + Misses 252 251 -1 - Partials 158 161 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adobe-bot commented 3 weeks ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	96	100	75

adobe-bot commented 3 weeks ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	100	75

adobe-bot commented 3 weeks ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 3 weeks ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 3 weeks ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 3 weeks ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	100	75

adobe-bot commented 3 weeks ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	94	96	100	75

adobe-bot commented 3 weeks ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 3 weeks ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 3 weeks ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe / aem-core-forms-components