search

adobe / aem-core-forms-components

Apache License 2.0
26 stars 50 forks source link

Dev to master PR #1295

Closed TalmizAhmed closed 3 months ago

TalmizAhmed commented 3 months ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

adobe-bot commented 3 months ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75
adobe-bot commented 3 months ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 92 96 100 75
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 83.07692% with 11 lines in your changes missing coverage. Please review.

Project coverage is 81.52%. Comparing base (c98ae52) to head (debfe3b). Report is 571 commits behind head on master.

Files Patch % Lines
...ore/components/util/AbstractFormComponentImpl.java 70.00% 3 Missing and 3 partials :warning:
...e/components/internal/form/ReservedProperties.java 71.42% 4 Missing :warning:
...ponents/internal/models/v1/form/FileInputImpl.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1295 +/- ## ============================================ - Coverage 81.54% 81.52% -0.03% - Complexity 828 847 +19 ============================================ Files 95 96 +1 Lines 2222 2252 +30 Branches 303 307 +4 ============================================ + Hits 1812 1836 +24 - Misses 252 256 +4 - Partials 158 160 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.