adobe / aem-core-forms-components

Apache License 2.0
25 stars 49 forks source link

Fixing edge cases related to options in dropdown #1297

Closed rismehta closed 1 week ago

rismehta commented 2 weeks ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.58%. Comparing base (d92ce31) to head (a5e47be). Report is 1 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1297 +/- ## ========================================= Coverage 81.58% 81.58% Complexity 847 847 ========================================= Files 96 96 Lines 2259 2259 Branches 306 306 ========================================= Hits 1843 1843 Misses 257 257 Partials 159 159 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adobe-bot commented 2 weeks ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75
adobe-bot commented 2 weeks ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 92 96 100 75
adobe-bot commented 2 weeks ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 2 weeks ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 2 weeks ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 88 96 100 75
adobe-bot commented 2 weeks ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75
adobe-bot commented 2 weeks ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 2 weeks ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 2 weeks ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 2 weeks ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 93 96 100 75
adobe-bot commented 2 weeks ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75
adobe-bot commented 2 weeks ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 2 weeks ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 2 weeks ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 1 week ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
rismehta commented 1 week ago

Got an update, that the buddy build worked successfully, merging this