Password comp - Githubissues

devgurjar commented 4 months ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

adobe-bot commented 4 months ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot commented 4 months ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot commented 4 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 4 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 4 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.50%. Comparing base (6a34c69) to head (5adab11).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #1316 +/- ## ============================================ + Coverage 82.38% 82.50% +0.12% - Complexity 946 959 +13 ============================================ Files 105 106 +1 Lines 2430 2447 +17 Branches 332 334 +2 ============================================ + Hits 2002 2019 +17 Misses 260 260 Partials 168 168 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

adobe-bot commented 2 months ago

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot commented 2 months ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	91	96	96	75

adobe-bot commented 2 months ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot commented 2 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 2 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 2 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

devgurjar commented 2 months ago

Can we use the new field type in this PR ? Please sync with talmiz on this

Yes we have used new field type in this PR, please refer to this commit https://git.corp.adobe.com/livecycle/af2-docs/pull/211/files#diff-a2a39757552dd1988f477b116329eba154e51bff6f2530d575b16fe6c76cd833R192

devgurjar commented 2 months ago

For opening and closing eye icon, we have changed code in theme https://github.com/adobe/aem-forms-theme-canvas/pull/45/commits/17c7b854a6c8979be062919477e93fe3ceb53037