image.1.json is returning model.json, as a fix revert PR-243 and adde…

adobe / aem-core-forms-components

Apache License 2.0

26 stars 50 forks source link

image.1.json is returning model.json, as a fix revert PR-243 and adde… #1323

Closed barshat7 closed 1 month ago

barshat7 commented 1 month ago

…d extensions

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

adobe-bot commented 1 month ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot commented 1 month ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	96	96	75

adobe-bot commented 1 month ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 1 month ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 1 month ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.70%. Comparing base (59e85d4) to head (13c4905).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #1323 +/- ## ============================================ - Coverage 81.73% 81.70% -0.04% + Complexity 853 851 -2 ============================================ Files 97 97 Lines 2267 2257 -10 Branches 305 303 -2 ============================================ - Hits 1853 1844 -9 Misses 255 255 + Partials 159 158 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.