FORMS-15466 Fixing conflicting vault filter

adobe / aem-core-forms-components

Apache License 2.0

26 stars 50 forks source link

FORMS-15466 Fixing conflicting vault filter #1326

Closed rismehta closed 1 month ago

rismehta commented 1 month ago

@review @vdua DOD(Yes)

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

adobe-bot commented 1 month ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot commented 1 month ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot commented 1 month ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 1 month ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 1 month ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.73%. Comparing base (41e4b47) to head (d49fcce).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #1326 +/- ## ========================================= Coverage 81.73% 81.73% Complexity 853 853 ========================================= Files 97 97 Lines 2267 2267 Branches 305 305 ========================================= Hits 1853 1853 Misses 255 255 Partials 159 159 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nit23uec commented 1 month ago

pls avoid referencing internal jira issues in public.

rismehta commented 1 month ago

pls avoid referencing internal jira issues in public.

Referring to internal JIRA IDs in GitHub repositories is a practice we have consistently followed. However, we avoid including internal Adobe VPN links in commit messages. Including JIRA ID's can enhance traceability and make it easier to track issues and changes over time.

This practice is also implemented in other Adobe GitHub projects, such as in this example: https://github.com/adobe/aem-core-wcm-components/pull/2804 https://github.com/adobe/aem-core-wcm-components/releases/tag/core.wcm.components.reactor-2.25.0

In some instances, if a GitHub issue is logged, so you won't find a corresponding JIRA ticket.