adobe / aem-core-forms-components

Standardized components to build forms with AEM Forms
Apache License 2.0
26 stars 58 forks source link

Name attribute removed for text component in 1.1.38v-SP20 vs 1.1.27v-SP17 #1338

Closed shravanthprasad closed 3 months ago

shravanthprasad commented 3 months ago

We have a planned upgrade for SP20 and core components v1.1.38 and we see the name attribute is removed from core forms text component. We had some JS logic on the field based on name attribute.

v1 1 27 v1 1 38
rismehta commented 3 months ago

@shravanthprasad In HTML, the div element does not standardly support the name attribute. The name attribute is typically used with form elements such as input, select, and textarea. Since it was incorrectly added before, we have now removed it. Could you please update your existing JavaScript code to accommodate this change? I understand this is a backward incompatible change, but aligning with standards will be beneficial in the long run.

shravanthprasad commented 3 months ago

Thanks @rismehta for the quick response