search

adobe / aem-core-forms-components

Standardized components to build forms with AEM Forms
Apache License 2.0
26 stars 58 forks source link

Fix default behaviour of enter press leading to form submission in core components. #1360

Closed muskgupta closed 3 months ago

muskgupta commented 3 months ago

Description

Pressing enter on core components redirects to thankyou page which is not the correct behaviour. This fix prevents the default behaviour of enter press on form level.

Related Issue

https://jira.corp.adobe.com/browse/FORMS-15630

Motivation and Context

How Has This Been Tested?

Tested on localhost deployment and test cases tested using cypress.

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.94%. Comparing base (ba35f75) to head (24b99f8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1360 +/- ## ========================================= Coverage 81.94% 81.94% Complexity 899 899 ========================================= Files 103 103 Lines 2337 2337 Branches 317 317 ========================================= Hits 1915 1915 Misses 259 259 Partials 163 163 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

muskgupta commented 3 months ago

Can we also change the type of submit button in this PR, since the changes are related.

As discussed in scrum, will cover in separate PR.

adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 92 96 96 75
adobe-bot commented 3 months ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 3 months ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75
adobe-bot commented 3 months ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 91 96 96 75
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 88 96 96 75
adobe-bot commented 3 months ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 3 months ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 91 96 96 75
adobe-bot commented 3 months ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 3 months ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75
adobe-bot commented 3 months ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 91 96 96 75
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 3 months ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 92 96 96 75
adobe-bot commented 3 months ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 3 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
muskgupta commented 3 months ago

Closed this PR and opened new https://github.com/adobe/aem-core-forms-components/pull/1363 as per discussion in scrum.