Updating type for button and actions core components - Githubissues

adobe / aem-core-forms-components

Apache License 2.0

26 stars 50 forks source link

Updating type for button and actions core components #1364

Open muskgupta opened 3 weeks ago

muskgupta commented 3 weeks ago

Description

Currently type for any type of button - button, reset or submit is "button" only. This change makes sure to map correct type for each type of button. (Submit -> type="submit", Reset -> type="reset", Button -> type="button")

Related Issue

https://jira.corp.adobe.com/browse/FORMS-15899

Motivation and Context

How Has This Been Tested?

Tested changes locally on localhost server to see correct type mapped to each type of button.

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes and the overall coverage did not decrease.
[x] All unit tests pass on CircleCi.
[x] I ran all tests locally and they pass.

adobe-bot commented 1 week ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot commented 1 week ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot commented 1 week ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 1 week ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 1 week ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious